Skip to content

[PWGJE] Add MC mixing and adjusting task for use on Hyperloop#12670

Merged
nzardosh merged 6 commits into
AliceO2Group:masterfrom
jkinner2:changingChange
Oct 6, 2025
Merged

[PWGJE] Add MC mixing and adjusting task for use on Hyperloop#12670
nzardosh merged 6 commits into
AliceO2Group:masterfrom
jkinner2:changingChange

Conversation

@jkinner2

Copy link
Copy Markdown
Contributor
  • added MC true mixing in the same way as reconstructed data
  • split producer task to own file (to allow subwagons with different configurations on Hyperloop)
    • added internal multiplicity estimate based on the number of JetTracks
  • extended invariant mass/correlation to eta meson
  • adjusted an issue in the efficiency process regarding bias towards selected tracks

save_testieTestThingie_deleteCommitLater

save_itFinallyCompiled_deleteCommitLater

addMcMixing_addEta_generalImprovements
@github-actions

github-actions Bot commented Aug 21, 2025

Copy link
Copy Markdown

O2 linter results: ❌ 1 errors, ⚠️ 0 warnings, 🔕 0 disabled

@jkinner2 jkinner2 marked this pull request as ready for review August 21, 2025 08:35
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 44989d8 at 2025-09-11 17:56:

No log files found

Full log here.

@fjonasALICE fjonasALICE left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is too much to look through everything, but @nzardosh since this does not touch any other task, we can approve without fear of breaking?

}
PROCESS_SWITCH(PhotonChargedTriggerProducer, processRecoPipmTPC, "process pipm (TPC) table (reconstructed)", false);

void processRecoPhotonPCM(soa::Join<aod::JetCollisions, aod::JCollisionPIs>::iterator const& collision, aod::Collisions const&,

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do you need aod::Collisions const& here?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The index of aod::Collisions is needed to match the photons to a JetCollision, since aod::V0PhotonsKF from the PCM task does not have an index to aod::JetCollisions

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but you use collision.collisionId(). I think since this is a number that is stored in JCollisions, then there is no need for aod::Collisions to be in the subscription. You could try this locally and see

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When trying to compile with aod::JetCollision const& collision instead of soa::Join<aod::JetCollisions, aod::JCollisionPIs>::iterator const& collision in the process function, I get a compilation error: 'has no member named 'collisionId''. So I would conclude the PIs table is necessary (I assume the globalIndex of aod::JetCollisions should not be used when the index of aod::Collisions is technically needed)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You still need aod::JCollisionPIs because thats where the Id colum is stored. However the aod::Collisions table is the one you probably dont need to subscribe to

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, sorry. I misunderstood. I have pushed the change

@nzardosh nzardosh self-requested a review October 6, 2025 13:27
@nzardosh nzardosh merged commit c739e8a into AliceO2Group:master Oct 6, 2025
13 of 14 checks passed
jinhyunni pushed a commit to jinhyunni/O2Physics that referenced this pull request Oct 11, 2025
ArkaprabhaSaha001 pushed a commit to ArkaprabhaSaha001/O2Physics that referenced this pull request Oct 21, 2025
ThePhDane pushed a commit to ThePhDane/O2Physics that referenced this pull request Nov 3, 2025
jloemker pushed a commit to jloemker/O2Physics that referenced this pull request Nov 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants